Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pre-commit so that it can run locally on every commit #2436

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Updated pre-commit so that it can run locally on every commit #2436

merged 5 commits into from
Jul 12, 2024

Conversation

nikhil25803
Copy link
Contributor

Issue addressed - #2419

Screenshot :
image

arkid15r
arkid15r suggested changes Jul 11, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
arkid15r
arkid15r reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

arkid15r
arkid15r previously approved these changes Jul 11, 2024
View reviewed changes
@nikhil25803
Copy link
Contributor Author

I am getting this error on running test cases.
image

Related to poetry install.
Error message - pyproject.toml changed significantly since poetry.lock was last generated. Run poetry lock [--no-update] to fix the lock file.

@nikhil25803
Copy link
Contributor Author

@arkid15r
Do I need to make changes in ci-cd.yml file to resolve this issue?
image

Adding run: poetry lock before run: poetry install/

@arkid15r
Copy link
Contributor

@arkid15r Do I need to make changes in ci-cd.yml file to resolve this issue? image

Adding run: poetry lock before run: poetry install/

No, just update your poetry.lock locally

@nikhil25803
Copy link
Contributor Author

nikhil25803 commented Jul 12, 2024 •
edited
Loading

I tried but still getting the same error

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.
Error: Process completed with exit code 1.

It worked!! Thanks @arkid15r

arkid15r
arkid15r approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r merged commit 3a62413 into OWASP-BLT:main Jul 12, 2024
8 checks passed
CodeWithBishal pushed a commit to CodeWithBishal/OWASP-BLT that referenced this pull request Jul 15, 2024
@nikhil25803 @CodeWithBishal
Updated pre-commit so that it can run locally on every commit (OWASP-…
f9b908b 
…BLT#2436)

* gitattributes changes

* moved pre-commit to dev dependency

* poetry.lock locally

* Update poetry.lock to match pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhil25803 @arkid15r